Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-1839 Use @ledgerhq/hw-app-cosmos instead of @cosmjs/LedgerSigner #1913

Merged
3 commits merged into from
Apr 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2022

Context (issues, jira)

https://ledgerhq.atlassian.net/browse/LIVE-1839

Description / Usage

The initial implementation of Cosmos JS didn't use @ledgerhq/hw-app-cosmos for signing transactions, because of supposed issues with the Amino signature format.
These issues proved non-existent, so we can actually use it instead of @cosmjs/ledger-amino that was used as a workaround.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

hakim-adamik and others added 2 commits April 21, 2022 18:28
* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* fix could not find optimisticOperation in redelegate transaction

* trigger bot

* trigger bot

* Cosmos JS (#1730)

* increase gas amplifier

* fix payload construction

handle payload atomic construction

* More accurate gas amplifier

* increase gas amplifier

* use same node for calculation and broadcast

* fix amount payload

* fix fees/gas calculation

* fix signature

fix public key when account is derivate

* fix fees regression

* More accurate pubkey selection

* don't use extra.tx_bytes

* fix pubkey selection

* simplify hex serialization

* update transaction: more strict types

* many things

restruct operation builder
simulate now return int
prepareTransaction use patch format

* accuracy

more accuracy int value
small refactor

* remove useless isPreValidation

* fix strange edge effect of ledger live desktop

* Update xpub during sync

* temporary enable log for bot

* LL-9159 cosmos node

* Update js-signOperation.ts

revert back test trace for bot

* fix signature

* fix redelegate payload

* fix payload send transaction when sendmax

* fix optimistic operation type

* fix typo

* bugfix

* fix regression

* update optimistic operation

fix regression
add operation type
more consistent fee

* fix prettier

* more deterministic transaction parsing

* clarify code readable

* adjust sender and recipient

* fix fees when is ibc transaction

* fix redelegations data mapping

* fix mixed styles

* fix array cast type

* fix more determinist operation data

* fix could not find optimisticOperation in redelegate transaction

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* restore getStargateRewardsState methode

* Cosmos JS (#1731)

* increase gas amplifier

* fix payload construction

handle payload atomic construction

* More accurate gas amplifier

* increase gas amplifier

* use same node for calculation and broadcast

* fix amount payload

* fix fees/gas calculation

* fix signature

fix public key when account is derivate

* fix fees regression

* More accurate pubkey selection

* don't use extra.tx_bytes

* fix pubkey selection

* simplify hex serialization

* update transaction: more strict types

* many things

restruct operation builder
simulate now return int
prepareTransaction use patch format

* accuracy

more accuracy int value
small refactor

* remove useless isPreValidation

* fix strange edge effect of ledger live desktop

* Update xpub during sync

* temporary enable log for bot

* LL-9159 cosmos node

* Update js-signOperation.ts

revert back test trace for bot

* fix signature

* fix redelegate payload

* fix payload send transaction when sendmax

* fix optimistic operation type

* fix typo

* bugfix

* fix regression

* update optimistic operation

fix regression
add operation type
more consistent fee

* fix prettier

* more deterministic transaction parsing

* clarify code readable

* adjust sender and recipient

* fix fees when is ibc transaction

* fix redelegations data mapping

* fix mixed styles

* fix array cast type

* fix more determinist operation data

* fix could not find optimisticOperation in redelegate transaction

* restore getStargateRewardsState methode

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* try to limit even more the cost of delegation

* lint

* Add files via upload

* amount of the operation more close

* return transaction in prepareTransaction

* prevent cosmos-js bot to do invalid scenarios of amount=0

* keep immutable paradigm for prepareTransaction

* bot: do not limit a maxRun for 'send some'

* Cosmos JS (#1743)

* increase gas amplifier

* fix payload construction

handle payload atomic construction

* More accurate gas amplifier

* increase gas amplifier

* use same node for calculation and broadcast

* fix amount payload

* fix fees/gas calculation

* fix signature

fix public key when account is derivate

* fix fees regression

* More accurate pubkey selection

* don't use extra.tx_bytes

* fix pubkey selection

* simplify hex serialization

* update transaction: more strict types

* many things

restruct operation builder
simulate now return int
prepareTransaction use patch format

* accuracy

more accuracy int value
small refactor

* remove useless isPreValidation

* fix strange edge effect of ledger live desktop

* Update xpub during sync

* temporary enable log for bot

* LL-9159 cosmos node

* Update js-signOperation.ts

revert back test trace for bot

* fix signature

* fix redelegate payload

* fix payload send transaction when sendmax

* fix optimistic operation type

* fix typo

* bugfix

* fix regression

* update optimistic operation

fix regression
add operation type
more consistent fee

* fix prettier

* more deterministic transaction parsing

* clarify code readable

* adjust sender and recipient

* fix fees when is ibc transaction

* fix redelegations data mapping

* fix mixed styles

* fix array cast type

* fix more determinist operation data

* fix could not find optimisticOperation in redelegate transaction

* restore getStargateRewardsState methode

* amount of the operation more close

* return transaction in prepareTransaction

* keep immutable paradigm for prepareTransaction

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* add .github/workflows/bot7-meredenis.yml

* fix amount update in prepareTransaction

* fix amount control to be more specific

* fix BigNumber compare

* Cosmos JS (#1746)

* increase gas amplifier

* fix payload construction

handle payload atomic construction

* More accurate gas amplifier

* increase gas amplifier

* use same node for calculation and broadcast

* fix amount payload

* fix fees/gas calculation

* fix signature

fix public key when account is derivate

* fix fees regression

* More accurate pubkey selection

* don't use extra.tx_bytes

* fix pubkey selection

* simplify hex serialization

* update transaction: more strict types

* many things

restruct operation builder
simulate now return int
prepareTransaction use patch format

* accuracy

more accuracy int value
small refactor

* remove useless isPreValidation

* fix strange edge effect of ledger live desktop

* Update xpub during sync

* temporary enable log for bot

* LL-9159 cosmos node

* Update js-signOperation.ts

revert back test trace for bot

* fix signature

* fix redelegate payload

* fix payload send transaction when sendmax

* fix optimistic operation type

* fix typo

* bugfix

* fix regression

* update optimistic operation

fix regression
add operation type
more consistent fee

* fix prettier

* more deterministic transaction parsing

* clarify code readable

* adjust sender and recipient

* fix fees when is ibc transaction

* fix redelegations data mapping

* fix mixed styles

* fix array cast type

* fix more determinist operation data

* fix could not find optimisticOperation in redelegate transaction

* restore getStargateRewardsState methode

* amount of the operation more close

* return transaction in prepareTransaction

* keep immutable paradigm for prepareTransaction

* fix amount update in prepareTransaction

* fix amount control to be more specific

* fix BigNumber compare

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* fix spendableBalance

* Cosmos JS (#1749)

* increase gas amplifier

* fix payload construction

handle payload atomic construction

* More accurate gas amplifier

* increase gas amplifier

* use same node for calculation and broadcast

* fix amount payload

* fix fees/gas calculation

* fix signature

fix public key when account is derivate

* fix fees regression

* More accurate pubkey selection

* don't use extra.tx_bytes

* fix pubkey selection

* simplify hex serialization

* update transaction: more strict types

* many things

restruct operation builder
simulate now return int
prepareTransaction use patch format

* accuracy

more accuracy int value
small refactor

* remove useless isPreValidation

* fix strange edge effect of ledger live desktop

* Update xpub during sync

* temporary enable log for bot

* LL-9159 cosmos node

* Update js-signOperation.ts

revert back test trace for bot

* fix signature

* fix redelegate payload

* fix payload send transaction when sendmax

* fix optimistic operation type

* fix typo

* bugfix

* fix regression

* update optimistic operation

fix regression
add operation type
more consistent fee

* fix prettier

* more deterministic transaction parsing

* clarify code readable

* adjust sender and recipient

* fix fees when is ibc transaction

* fix redelegations data mapping

* fix mixed styles

* fix array cast type

* fix more determinist operation data

* fix could not find optimisticOperation in redelegate transaction

* restore getStargateRewardsState methode

* amount of the operation more close

* return transaction in prepareTransaction

* keep immutable paradigm for prepareTransaction

* fix amount update in prepareTransaction

* fix amount control to be more specific

* fix BigNumber compare

* fix spendableBalance

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* separate postBuildTransaction logic + fix use useAllAmount

* Cosmos JS (#1751)

* increase gas amplifier

* fix payload construction

handle payload atomic construction

* More accurate gas amplifier

* increase gas amplifier

* use same node for calculation and broadcast

* fix amount payload

* fix fees/gas calculation

* fix signature

fix public key when account is derivate

* fix fees regression

* More accurate pubkey selection

* don't use extra.tx_bytes

* fix pubkey selection

* simplify hex serialization

* update transaction: more strict types

* many things

restruct operation builder
simulate now return int
prepareTransaction use patch format

* accuracy

more accuracy int value
small refactor

* remove useless isPreValidation

* fix strange edge effect of ledger live desktop

* Update xpub during sync

* temporary enable log for bot

* LL-9159 cosmos node

* Update js-signOperation.ts

revert back test trace for bot

* fix signature

* fix redelegate payload

* fix payload send transaction when sendmax

* fix optimistic operation type

* fix typo

* bugfix

* fix regression

* update optimistic operation

fix regression
add operation type
more consistent fee

* fix prettier

* more deterministic transaction parsing

* clarify code readable

* adjust sender and recipient

* fix fees when is ibc transaction

* fix redelegations data mapping

* fix mixed styles

* fix array cast type

* fix more determinist operation data

* fix could not find optimisticOperation in redelegate transaction

* restore getStargateRewardsState methode

* amount of the operation more close

* return transaction in prepareTransaction

* keep immutable paradigm for prepareTransaction

* fix amount update in prepareTransaction

* fix amount control to be more specific

* fix BigNumber compare

* fix spendableBalance

* separate postBuildTransaction logic + fix use useAllAmount

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* bot: lower claim reward at 1000

* bot: lower the # of // delegations for cosmos

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* bot: fixes 0 atom undelegate

* trigger bot

* v21.33.1-cosmos.0

* trigger bot

* trigger bot

* update cosmos specs for claim rewards

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* fix rewards

* trigger bot

* Cosmos JS (#1761)

* increase gas amplifier

* fix payload construction

handle payload atomic construction

* More accurate gas amplifier

* increase gas amplifier

* use same node for calculation and broadcast

* fix amount payload

* fix fees/gas calculation

* fix signature

fix public key when account is derivate

* fix fees regression

* More accurate pubkey selection

* don't use extra.tx_bytes

* fix pubkey selection

* simplify hex serialization

* update transaction: more strict types

* many things

restruct operation builder
simulate now return int
prepareTransaction use patch format

* accuracy

more accuracy int value
small refactor

* remove useless isPreValidation

* fix strange edge effect of ledger live desktop

* Update xpub during sync

* temporary enable log for bot

* LL-9159 cosmos node

* Update js-signOperation.ts

revert back test trace for bot

* fix signature

* fix redelegate payload

* fix payload send transaction when sendmax

* fix optimistic operation type

* fix typo

* bugfix

* fix regression

* update optimistic operation

fix regression
add operation type
more consistent fee

* fix prettier

* more deterministic transaction parsing

* clarify code readable

* adjust sender and recipient

* fix fees when is ibc transaction

* fix redelegations data mapping

* fix mixed styles

* fix array cast type

* fix more determinist operation data

* fix could not find optimisticOperation in redelegate transaction

* restore getStargateRewardsState methode

* amount of the operation more close

* return transaction in prepareTransaction

* keep immutable paradigm for prepareTransaction

* fix amount update in prepareTransaction

* fix amount control to be more specific

* fix BigNumber compare

* fix spendableBalance

* separate postBuildTransaction logic + fix use useAllAmount

* fix rewards

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* fix unbondings

* fix fees calculation and add cache usage

* trigger bot

* v21.33.1-cosmos.1

* v21.33.1-cosmos.2

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* cosmos bot: lower the amount for general tx & lower part alloc in delegate

* ensure for all cosmos mutation that only one op results of a tx

* be more conform between optimistic and final operation

* be more conform between optimistic and final operation (#1786)

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* Filecoin fixes (#1740)

* make use of useAllAmount flag

* make use of useAllAmount on signing tx process

* refactor signOperation process to use extra field better

* add deviceTransactionConfig for filecoin

* re org fields for confirm tx

* change fields order

* add extra field parsers

* move extra field parsers to the correct file

* fix lint issue

* Create dependencies.md

* Add env var to enable learn staging URL

* lint

* Bump urijs from 1.19.8 to 1.19.9 (#1774)

Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.9.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](medialize/URI.js@v1.19.8...v1.19.9)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump urijs from 1.19.8 to 1.19.9 in /tools (#1776)

Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.9.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](medialize/URI.js@v1.19.8...v1.19.9)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump urijs from 1.19.8 to 1.19.9 in /cli (#1775)

Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.9.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](medialize/URI.js@v1.19.8...v1.19.9)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump urijs from 1.19.8 to 1.19.9 in /mobile-test-app (#1773)

Bumps [urijs](https://github.com/medialize/URI.js) from 1.19.8 to 1.19.9.
- [Release notes](https://github.com/medialize/URI.js/releases)
- [Changelog](https://github.com/medialize/URI.js/blob/gh-pages/CHANGELOG.md)
- [Commits](medialize/URI.js@v1.19.8...v1.19.9)

---
updated-dependencies:
- dependency-name: urijs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump plist from 3.0.1 to 3.0.4 in /mobile-test-app (#1767)

Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.1 to 3.0.4.
- [Release notes](https://github.com/TooTallNate/node-plist/releases)
- [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md)
- [Commits](https://github.com/TooTallNate/node-plist/commits)

---
updated-dependencies:
- dependency-name: plist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* disable a failing test of countervalues (#1778)

temporarily disable a countervalues api test. team informed.

* re-enable countervalues test (#1779)

* fix device actions used by bot and add new test case (#1784)

* Fixes for XTZ JS (still under experimental, no impact)

* Update Ethereum related libraries (#1780)

* Update Ethereum related libraries

* axios update

* bitcoin bot to slack on ll-bitcoin-ci

* v21.34.0-cosmos.0

* use old code logic

* Cosmos JS (#1791)

* be more conform between optimistic and final operation

* use old code logic

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* fix senders/recipients regression

* Cosmos JS (#1793)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* fix duplicate data

* Cosmos JS (#1794)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* fix duplicate data (again)

* Cosmos JS (#1795)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* append block height

* Cosmos JS (#1796)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

* append block height

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* trigger bot

* Cosmos-JS - Fix random balance changes (#1797)

* Cleanup Cosmos.api and remove default values

* forEach doesn't behave well with async/await

* Restore some necessary API default values

* Fix lint error

* trigger bot

* Fix setting of experimental JS currencies

* fix specific empty amount case in reward transaction

* Cosmos JS (#1799)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

* append block height

* fix specific empty amount case in reward transaction

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* temporary debug operation broadcasted

* use toOperationRaw method

* return  patchedOperation

* Cosmos JS (#1800)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

* append block height

* fix specific empty amount case in reward transaction

* temporary debug operation broadcasted

* use toOperationRaw method

* return  patchedOperation

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* restore broadcast operation

* Update js-synchronisation.ts

* remove block height support

* Cosmos JS (#1801)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

* append block height

* fix specific empty amount case in reward transaction

* temporary debug operation broadcasted

* use toOperationRaw method

* return  patchedOperation

* restore broadcast operation

* Update js-synchronisation.ts

* remove block height support

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* v21.34.1-cosmos.3

* Revert "remove block height support"

This reverts commit eb7198f.

* log allOperationsMatchingId

* lint

* augment the nb of cosmos accounts

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* enable crypto_org to run tests

* More strict type

* reverse order of validators

* Cosmos JS (#1803)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

* append block height

* fix specific empty amount case in reward transaction

* temporary debug operation broadcasted

* use toOperationRaw method

* return  patchedOperation

* restore broadcast operation

* Update js-synchronisation.ts

* remove block height support

* Revert "remove block height support"

This reverts commit eb7198f.

* More strict type

* reverse order of validators

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* fix validators type in createTransmission

* add sequence to ops

* strict output getAccount type

* fix operations sequence

* Cosmos JS (#1804)

* be more conform between optimistic and final operation

* use old code logic

* fix senders/recipients regression

* fix duplicate data

* fix duplicate data (again)

* append block height

* fix specific empty amount case in reward transaction

* temporary debug operation broadcasted

* use toOperationRaw method

* return  patchedOperation

* restore broadcast operation

* Update js-synchronisation.ts

* remove block height support

* Revert "remove block height support"

This reverts commit eb7198f.

* More strict type

* reverse order of validators

* fix validators type in createTransmission

* add sequence to ops

* strict output getAccount type

* fix operations sequence

Co-authored-by: Alexandre Alouit <alexandre.alouit@gmail.com>

* Add a workaround that prevent 2 last operations to be same id (#1807)

* Fixes deduplication logic of mergeOps

* Revert "Add a workaround that prevent 2 last operations to be same id (#1807)"

This reverts commit b0e55cd.

* fix multiple tx messages

* Remove all libcore codebase

* remove calculateFees libcore logic

* trigger some bot (commit to revert before merging this PR)

* lint

* remove useless cli test run

* fix type issue

* cli update

* Revert "trigger some bot (commit to revert before merging this PR)"

This reverts commit add2667.

* update cli/README

* don't use round ceil

* add comment note

* sync with upstream

* fix merge

* Cosmos js (#1832)

Document Nano app limitations + minor fix on reward amounts

* Modularize the all.libcore.tests (#1834)

* LL-1589 more robust bitcoin retry (#1835)

* fix bot

* fix sync error exception process

* Additional cleanup on bitcoin implem

* fix mixed transaction sync

fix edge case when we have delegate and reward like tx  DF458FE6A82C310837D7A33735FA5298BCF71B0BFF7A4134641AAE30F6F10501

* fix balance

incorrect balance when have unbonding data

* Set bot on family/cosmos branch

* fix bch address convert issue (#1847)

* Hotfix - v21.36.1 on Develop (#1860)

* bugfix/swap-operation-details-duplicates getCompleteSwapHistory modified to avoid returning the same swap operations multiple times (#1854)

* v21.36.1

Co-authored-by: Côme Grellard <come.grellard@ledger.fr>

* Remove all libcore codebase (#1831)

* Remove all libcore codebase

* trigger some bot (commit to revert before merging this PR)

* lint

* remove useless cli test run

* fix type issue

* cli update

* Revert "trigger some bot (commit to revert before merging this PR)"

This reverts commit add2667.

* update cli/README

* fix merge

* Cosmos js (#1832)

Document Nano app limitations + minor fix on reward amounts

* Modularize the all.libcore.tests (#1834)

* Additional cleanup on bitcoin implem

* LIVE-1873

Co-authored-by: wa-aal <93649819+wa-aal@users.noreply.github.com>
Co-authored-by: haammar-ledger <hakim.aammar-ext@ledger.fr>

* Add ETH goerli (#1841)

* add ETH goerli

* add goerli test

* Cosmos fixes (#1846)

* Set bot on family/cosmos branch

* LIVE-1873

* trigger bot

* Family/crypto org (#1852)

* LIVE-1743 Fix crypto.com address derivation path (#1836)

* trigger bot

* Tentative to fix crypto.com use of address

Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com>

* [LIVE-1174] - Feature: Upgrade NFT Architecture (#1805)

* Fix wrong NFTResource typing

* Update NFT types to ProtoNFT

* Update NFT Id to contain currency

* Update NFT Helpers for new model

* Update Eth API metadata call to include chainId

* Move nft metadata resolution to bridge

* Update NftMetadaProvider logic to use bridge

* Update prepare tx of ERC721/1155 w/ new model

* Update CLI for new NFT model

* Add getNftCapabilities to nft support

* Naming + fixing ERC1155 quantity potentially falsy

* Make CLI use the LLC branch hash

* Add type to nftMetadataResolver param + use of sync metadata

* Remove useless import

* Remove useless comment in CLI formatters

* Add comment to nftsByCollection helper

* Add comments + types to NFT metadata call batchers

* Fix sync metadata resolution for Eth family

* Add return type to nftMetadataResolver + decodeNftId

* Add polygon to NFT currencies (#1848)

* [LIVE-1909] - Bugfix: OpenSea Lazy mint quantity fix (#1862)

* Fix lazyminting issue for nfts quantity

* run ci

* Reset CLI LLC dep

* LIVE-1890 Replace all deprecated uses of open(deviceId) with withDevice (#1856)

* Fix nft operations wrong order to infer balance (#1865)

* Replace all deprecated uses of open(deviceId) with withDevice (#1864)

* [LIVE-1911][LIVE-1912] Feature - Add collection name resolver to eth familly (#1863)

* Change nfts resolvers from Bridge type

* Update eth nft resolvers & add collection resolver

* Add loadCollectionMetadata to nft context

* Change eth NFT prepareTransaction to use collection call instead of nft metadata call

* Bump plist from 3.0.4 to 3.0.5 in /mobile-test-app (#1849)

Bumps [plist](https://github.com/TooTallNate/node-plist) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/TooTallNate/node-plist/releases)
- [Changelog](https://github.com/TooTallNate/plist.js/blob/master/History.md)
- [Commits](https://github.com/TooTallNate/node-plist/commits)

---
updated-dependencies:
- dependency-name: plist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cocoapods-downloader from 1.3.0 to 1.6.3 in /mobile-test-app (#1857)

Bumps [cocoapods-downloader](https://github.com/CocoaPods/cocoapods-downloader) from 1.3.0 to 1.6.3.
- [Release notes](https://github.com/CocoaPods/cocoapods-downloader/releases)
- [Changelog](https://github.com/CocoaPods/cocoapods-downloader/blob/master/CHANGELOG.md)
- [Commits](CocoaPods/cocoapods-downloader@1.3.0...1.6.3)

---
updated-dependencies:
- dependency-name: cocoapods-downloader
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump ansi-regex from 3.0.0 to 3.0.1 (#1850)

Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/chalk/ansi-regex/releases)
- [Commits](chalk/ansi-regex@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: ansi-regex
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Solana staking (#1844)

* solana add initial staking support

* solana improve staking

* solana fix typos

* solana fix cli format for staking

* solana add device fields for stake create acc

* solana add stake delegate support

* solana fix lint

* solana add stake undelegate

* solana add stake withdraw

* solana add stake split

* solana add stakes loading

* solana improve staking

* solana introduce solana resources

* solana add preload data

* solana add hydrate to bridge

* solana add stake actions

* solana improve staking

* solana add meta to validators

* solana add validator name

* solana fix seed for stake accs

* solana add stake reward

* solana improve staking

* solana stake add withdrawable amount

* solana refactor framework

* solana fix tests

* solana make auto delegation mandatory

* solana sort stakes

* solana fix error key

* solana add delegation validator validation

* solana add staking create acc tests

* solana add staking delegate tests

* solana add stake undelegate tests

* solana remove redundant checks for stake delegation

* solana skip options validations on cli level

* solana skip undelegate options validations on cli level

* solana improve staking tests

* solana add delegatable check to staking

* solana fix estimate max spendable

* solana add delegation active test

* solana add stake state tests

* solana introduce validators app validators

* solana add validators for testnet & devnet

* solana refactor validators app validators

* solana update meta of stakes

* solana update sort order of stakes

* solana add delegated op type

* solana shuffle staking validators

* solana fix stake withdraw optimistic value

* solana clean comments

* solana update mock data

* solana add initial staking bot specs

* solana add staking bot specs

* solana move ledger vote acc to utils

* solana add swap util

* solana update device tx config

* solana fix lint

* Add bot for Solana

* Solana staking integration (#1825)

* solana add initial staking support

* solana improve staking

* solana fix typos

* solana fix cli format for staking

* solana add device fields for stake create acc

* solana add stake delegate support

* solana fix lint

* solana add stake undelegate

* solana add stake withdraw

* solana add stake split

* solana add stakes loading

* solana improve staking

* solana introduce solana resources

* solana add preload data

* solana add hydrate to bridge

* solana add stake actions

* solana improve staking

* solana add meta to validators

* solana add validator name

* solana fix seed for stake accs

* solana add stake reward

* solana improve staking

* solana stake add withdrawable amount

* solana refactor framework

* solana fix tests

* solana make auto delegation mandatory

* solana sort stakes

* solana fix error key

* solana add delegation validator validation

* solana add staking create acc tests

* solana add staking delegate tests

* solana add stake undelegate tests

* solana remove redundant checks for stake delegation

* solana skip options validations on cli level

* solana skip undelegate options validations on cli level

* solana improve staking tests

* solana add delegatable check to staking

* solana fix estimate max spendable

* solana add delegation active test

* solana add stake state tests

* solana introduce validators app validators

* solana add validators for testnet & devnet

* solana refactor validators app validators

* solana update meta of stakes

* solana update sort order of stakes

* solana add delegated op type

* solana shuffle staking validators

* solana fix stake withdraw optimistic value

* solana clean comments

* solana update mock data

* solana add initial staking bot specs

* solana add staking bot specs

* solana move ledger vote acc to utils

* solana add swap util

* solana update device tx config

* solana fix lint

* Change seed for Solana bot

* Change seed again for Solana bot

* trigger bot

* solana add stake percent calc fn

* solana update spec for new nano app

* solana set minimum required nano app version

* solana add validators app url env variable

* fix bad merge

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* Solana bot - increase timeout and decrease minimum to delegate

* trigger bot

* trigger bot

* trigger bot

* trigger bot

* Setup the bot to not use the validators.app proxy (yet)

* Replace all deprecated uses of open(deviceId) with withDevice

* Solana - replace open(deviceId) with withDevice

* Remove custom data

* Update solana bot

Co-authored-by: konoart <konoart@solana.com>
Co-authored-by: konoart <91595347+konoart@users.noreply.github.com>
Co-authored-by: lambertkevin <kevin.lambert@ledger.fr>

* v22.0.0

* (Solana): fix missing superstruct dependency -> making app crashes

* v21.36.2

* Revert "Merge remote-tracking branch 'origin/release/v22.0.0'"

This reverts commit 1e72d95, reversing
changes made to 77dfa66.

* Revert "Merge pull request #1853 from LedgerHQ/release/v22.0.0"

This reverts commit 78650fe, reversing
changes made to 7ef865d.

* (Solana): fix missing superstruct dependency -> making app crashes

* v21.36.2

* Update Cosmos dataset snapshot to fix test (#1861)

* move from cosmjs/ledger-amino to ledgerhq/hw-app-cosmos

* fix message and signature

* fix derivation path

* remove cosmjs/ledger-amino package

Co-authored-by: Gaëtan Renaudeau <renaudeau.gaetan@gmail.com>
Co-authored-by: wa-aal <93649819+wa-aal@users.noreply.github.com>
Co-authored-by: Emmanuel <emmanuelm41@gmail.com>
Co-authored-by: Olivier Freyssinet <olivier.freyssinet@ledger.fr>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: haammar-ledger <hakim.aammar-ext@ledger.fr>
Co-authored-by: Hakim <59644786+haammar-ledger@users.noreply.github.com>
Co-authored-by: hzheng-ledger <71653044+hzheng-ledger@users.noreply.github.com>
Co-authored-by: Valentin D. Pinkman <valentin.d.pinkman@hey.com>
Co-authored-by: Kévin Lambert <44363395+lambertkevin@users.noreply.github.com>
Co-authored-by: Côme Grellard <come.grellard@ledger.fr>
Co-authored-by: Thomas Nguy <81727899+thomas-nguy@users.noreply.github.com>
Co-authored-by: lambertkevin <kevin.lambert@ledger.fr>
Co-authored-by: konoart <konoart@solana.com>
Co-authored-by: konoart <91595347+konoart@users.noreply.github.com>
Co-authored-by: LFBarreto <lfb.access@gmail.com>
Co-authored-by: henrily-ledger <33897120+henrily-ledger@users.noreply.github.com>
@ghost ghost self-requested a review as a code owner April 26, 2022 08:10
@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) Apr 26, 2022 at 0:41AM (UTC)

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1913 (f191de2) into develop (76e3f11) will decrease coverage by 9.64%.
The diff coverage is 18.18%.

❗ Current head f191de2 differs from pull request most recent head 5d1be70. Consider uploading reports for the commit 5d1be70 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1913      +/-   ##
===========================================
- Coverage    69.03%   59.39%   -9.65%     
===========================================
  Files          545      510      -35     
  Lines        23507    21114    -2393     
  Branches      6185     5689     -496     
===========================================
- Hits         16229    12540    -3689     
- Misses        7237     8553    +1316     
+ Partials        41       21      -20     
Impacted Files Coverage Δ
src/families/cosmos/js-signOperation.ts 16.66% <14.28%> (-2.46%) ⬇️
src/families/cosmos/js-prepareTransaction.ts 95.91% <100.00%> (-0.09%) ⬇️
src/families/bitcoin/networks.ts 5.88% <0.00%> (-80.40%) ⬇️
src/families/crypto_org/api/sdk.ts 16.85% <0.00%> (-78.66%) ⬇️
src/families/celo/hw-app-celo.ts 3.38% <0.00%> (-77.97%) ⬇️
src/families/bitcoin/js-signOperation.ts 21.53% <0.00%> (-75.39%) ⬇️
src/families/celo/js-getFeesForTransaction.ts 26.66% <0.00%> (-73.34%) ⬇️
src/hw/signTransaction/ripple.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/celo/js-buildTransaction.ts 27.27% <0.00%> (-72.73%) ⬇️
src/families/elrond/api/sdk.ts 22.64% <0.00%> (-71.70%) ⬇️
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e3f11...5d1be70. Read the comment docs.

@ghost ghost merged commit 77e5ff6 into develop Apr 29, 2022
@ghost ghost deleted the family/cosmos branch April 29, 2022 08:16
This was referenced May 5, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants